[GitHub] carbondata pull request #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the R...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4520/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3292/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    retest this please
   



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3295/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4523/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4538/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2090
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3310/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2090#discussion_r176896518
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/DataRetentionConcurrencyTestCase.scala ---
    @@ -18,44 +18,63 @@
     package org.apache.carbondata.spark.testsuite.dataretention
     
     import java.util
    -import java.util.concurrent.{Callable, Executors, Future}
    +import java.util.concurrent.{Callable, ExecutorService, Executors, Future}
     
     import scala.collection.JavaConverters._
     
     import org.apache.spark.sql.test.util.QueryTest
    -import org.scalatest.BeforeAndAfterAll
    +import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
     
     import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.datamap.dev.DataMapWriter
    +import org.apache.carbondata.core.datamap.dev.cgdatamap.{CoarseGrainDataMap, CoarseGrainDataMapFactory}
    +import org.apache.carbondata.core.datamap.{DataMapDistributable, DataMapMeta, Segment}
    +import org.apache.carbondata.core.datastore.page.ColumnPage
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier
    +import org.apache.carbondata.core.metadata.schema.table.DataMapSchema
    +import org.apache.carbondata.core.scan.filter.intf.ExpressionType
     import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.events.Event
     
     
     /**
      * This class contains DataRetention concurrency test cases
      */
    -class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll {
    +class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll with BeforeAndAfterEach {
    --- End diff --
   
    I think this testcase is not valid anymore, please delete this suite


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2090#discussion_r176897338
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/DataRetentionConcurrencyTestCase.scala ---
    @@ -18,44 +18,63 @@
     package org.apache.carbondata.spark.testsuite.dataretention
     
     import java.util
    -import java.util.concurrent.{Callable, Executors, Future}
    +import java.util.concurrent.{Callable, ExecutorService, Executors, Future}
     
     import scala.collection.JavaConverters._
     
     import org.apache.spark.sql.test.util.QueryTest
    -import org.scalatest.BeforeAndAfterAll
    +import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
     
     import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.datamap.dev.DataMapWriter
    +import org.apache.carbondata.core.datamap.dev.cgdatamap.{CoarseGrainDataMap, CoarseGrainDataMapFactory}
    +import org.apache.carbondata.core.datamap.{DataMapDistributable, DataMapMeta, Segment}
    +import org.apache.carbondata.core.datastore.page.ColumnPage
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier
    +import org.apache.carbondata.core.metadata.schema.table.DataMapSchema
    +import org.apache.carbondata.core.scan.filter.intf.ExpressionType
     import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.events.Event
     
     
     /**
      * This class contains DataRetention concurrency test cases
      */
    -class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll {
    +class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll with BeforeAndAfterEach {
    --- End diff --
   
    @jackylk already deleted in current master hence i am closing this pr


---

[qiuchenjian-2]

Github user anubhav100 closed the pull request at:

    https://github.com/apache/carbondata/pull/2090


---