[GitHub] carbondata pull request #2091: [CARBONDATA-2258] Separate visible and invisi...

classic Classic list List threaded Threaded
35 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2091: [CARBONDATA-2258] Separate visible and invisi...

qiuchenjian-2
GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/2091

    [CARBONDATA-2258] Separate visible and invisible segments info into two files to reduce the size of tablestatus file.

    The size of the tablestatus file is getting larger, there are many places will scan this file and it will impact the performance of reading this file.
    According to the discussion on [thread](http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/The-size-of-the-tablestatus-file-is-getting-larger-does-it-impact-the-performance-of-reading-this-fi-td41941.html), it can *append* the
    invisible segment list to the file called 'tablestatus.history' when execute
    command 'CLEAN FILES FOR TABLE' (in method 'SegmentStatusManager.deleteLoadsAndUpdateMetadata') every time, separate visible and invisible segments into two files(tablestatus file and tablestatus.history file).
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-2258

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2091.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2091
   
----
commit 46301958107bd7ee2800eb891d19c885772b6a6c
Author: Zhang Zhichao <441586683@...>
Date:   2018-03-22T17:39:36Z

    [CARBONDATA-2258] Separate visible and invisible segments info into two files to reduce the size of tablestatus file.
   
    The size of the tablestatus file is getting larger, there are many places will scan this file and it will impact the performance of reading this file.
    According to the discussion on [thread|http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/The-size-of-the-tablestatus-file-is-getting-larger-does-it-impact-the-performance-of-reading-this-fi-td41941.html], it can *append* the
    invisible segment list to the file called 'tablestatus.history' when execute
    command 'CLEAN FILES FOR TABLE' (in method 'SegmentStatusManager.deleteLoadsAndUpdateMetadata') every time, separate visible and invisible segments into two files(tablestatus file and tablestatus.history file).

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3283/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4511/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4017/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3288/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4516/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3303/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4531/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    retest sdv please.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4031/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3308/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4536/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4542/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4035/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3318/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4545/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2091: [CARBONDATA-2258] Separate visible and invisible seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2091
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4040/



---
12