[GitHub] carbondata pull request #2107: [CARBONDATA-2287] events added for alter hive...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/2107

    [CARBONDATA-2287] events added for alter hive partition table

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done NR, All UT and SDV pass report is enough.
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-2287

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2107
   
----
commit 7f46f86e2fcaaf385dfe426ecc0617155401cca7
Author: rahulforallp <rahul.kumar@...>
Date:   2018-03-27T06:50:04Z

    [CARBONDATA-2287] events added for alter hive partition table

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3384/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4609/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4110/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4612/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3387/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4112/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4113/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4615/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3390/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4117/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2107#discussion_r177409405
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/MeasureFieldConverterImpl.java ---
    @@ -95,8 +95,9 @@ public void convert(CarbonRow row, BadRecordLogHolder logHolder)
             }
             row.update(output, index);
           } catch (NumberFormatException e) {
    -        LOGGER.warn(
    -            "Cant not convert value to Numeric type value. Value considered as null.");
    +        if (LOGGER.isDebugEnabled()) {
    +          LOGGER.warn("Can not convert value to Numeric type value. Value considered as null.");
    --- End diff --
   
    Change it to Logger.debug


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2107#discussion_r177410099
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java ---
    @@ -338,7 +339,23 @@ public static CarbonFactDataHandlerModel getCarbonFactDataHandlerModel(CarbonLoa
        */
       private static String getCarbonDataFolderLocation(CarbonDataLoadConfiguration configuration) {
         if (configuration.getDataWritePath() != null) {
    -      CarbonUtil.checkAndCreateFolder(configuration.getDataWritePath());
    +      String paths = configuration.getDataWritePath();
    +      AbsoluteTableIdentifier absoluteTableIdentifier = configuration.getTableIdentifier();
    +      String partPath = absoluteTableIdentifier.getTablePath();
    +      String[] partDirs = paths.split(partPath);
    +      // it will create folder one by one and apply the permissions
    +      // else creation of folder in one go will set the permission for last directory only
    +      if (partDirs.length > 1) {
    --- End diff --
   
    Can you add an example above with paths or partDirs for better understanding


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3395/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4620/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4123/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3397/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4622/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4125/



---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/carbondata/pull/2107
 
    retest sdv please


---