[GitHub] carbondata pull request #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment...

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment...

qiuchenjian-2
GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/2129

    [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock files before update metadata

    If there are some COMPACTED segments and their last modified time is within one hour, the segment lock files deletion operation will not be executed.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-2298_backport_1.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2129
   
----
commit 74dc33e7bba6c34c368b7df3a9aee17e891a5635
Author: Zhang Zhichao <441586683@...>
Date:   2018-04-01T16:18:06Z

    [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock files before update metadata
   
    If there are some COMPACTED segments and their last modified time is within one hour, the segment lock files deletion operation will not be executed.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4717/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3490/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4224/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3494/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4721/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4722/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3495/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4238/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment lock f...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2129
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2129: [CARBONDATA-2298][BACKPORT-1.3]Delete segment...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp closed the pull request at:

    https://github.com/apache/carbondata/pull/2129


---