[GitHub] carbondata pull request #2142: [CARBONDATA-2316] [WIP] Executor task is fail...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/2142

    [CARBONDATA-2316] [WIP] Executor task is failed but UI shows success issue is fixed …

     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata compact_task_faail_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2142
   
----
commit 1ac4d350c4b405b0ff65cb04909b02e3a43d7737
Author: rahulforallp <rahul.kumar@...>
Date:   2018-04-06T08:46:06Z

    [CARBONDATA-2316] Executor task is failed but UI shows success issue fixed

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4852/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3630/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4321/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3673/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4896/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4365/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2142#discussion_r180646025
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/AbstractResultProcessor.java ---
    @@ -37,7 +39,7 @@
        * @param resultIteratorList
        * @return
        */
    -  public abstract boolean execute(List<RawResultIterator> resultIteratorList);
    +  public abstract boolean execute(List<RawResultIterator> resultIteratorList) throws SparkException;
    --- End diff --
   
    You can only throw the exception that is sufficient


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2142#discussion_r180646852
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java ---
    @@ -165,8 +168,12 @@ public boolean execute(List<RawResultIterator> resultIteratorList) {
             readAndLoadDataFromSortTempFiles();
           }
           isCompactionSuccess = true;
    -    } catch (Exception e) {
    +    } catch (BadRecordFoundException e) {
    --- End diff --
   
    BadRecordFoundException  will never come in case of compaction so remove this catch block


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2142#discussion_r180646899
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java ---
    @@ -165,8 +168,12 @@ public boolean execute(List<RawResultIterator> resultIteratorList) {
             readAndLoadDataFromSortTempFiles();
           }
           isCompactionSuccess = true;
    -    } catch (Exception e) {
    +    } catch (BadRecordFoundException e) {
    +      LOGGER.error(e, "Compaction failed: " + e.getMessage());
    +    }
    +    catch (Exception e) {
           LOGGER.error(e, "Compaction failed: " + e.getMessage());
    +      throw new SparkException(e.getMessage());
    --- End diff --
   
    Remove throwing sparkException from everywhere in the code


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2142#discussion_r180646949
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java ---
    @@ -157,10 +160,15 @@ public boolean execute(List<RawResultIterator> resultIteratorList) {
             this.dataHandler.finish();
           }
           mergeStatus = true;
    -    } catch (Exception e) {
    +    } catch (BadRecordFoundException e) {
    --- End diff --
   
    Remove this catch block


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2142#discussion_r180645796
 
    --- Diff: processing/pom.xml ---
    @@ -34,6 +34,11 @@
       </properties>
     
       <dependencies>
    +    <dependency>
    +      <groupId>org.apache.spark</groupId>
    +      <artifactId>spark-core_${scala.binary.version}</artifactId>
    +      <version>${spark.version}</version>
    +    </dependency>
    --- End diff --
   
    Remove this dependency. Do not add spark dependency in processing layer until and unless really required


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4935/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3716/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4396/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3720/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4939/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4942/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3723/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2142
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4400/



---