[GitHub] carbondata pull request #2150: [CARBONDATA-2324] Support config ExecutorServ...

[qiuchenjian-2]

GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/2150

    [CARBONDATA-2324] Support config ExecutorService in search mode

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata searchmode_update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2150
   
----
commit 5635b7e635037d0c5c1e6e71e7c931a0f6efd1f2
Author: Manhua <kevinjmh@...>
Date:   2018-04-08T11:44:22Z

    support config ExecutorService in search mode

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4893/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3670/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4362/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    retest this please


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2150#discussion_r180989931
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1635,12 +1635,15 @@
       public static final String CARBON_SEARCH_MODE_ENABLE_DEFAULT = "false";
     
       /**
    -   * Num of threads used in query executor when using search mode.
    +   * Thread size of static ExecutorService in each Node when using search mode.
    +   * Default value is -1, it means that Executors.newCachedThreadPool() will be used to
    +   * maximize utilization. If thread numbers has to be limited, set it a positive Integer
    +   * will call Executors.newFixedThreadPool(int nThreads) instead
        */
       @CarbonProperty
       public static final String CARBON_SEARCH_MODE_THREAD = "carbon.search.mode.thread";
    --- End diff --
   
    please rename it to `CARBON_SEARCH_MODE_SCAN_THREAD`, it means the number of thread used to do the scan. There are other threads in thread mode, like handling the request from master


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4966/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4973/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4979/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4425/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2150
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2150


---