Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2152: [CARBONDATA-2155][CARBONDATA-2152]Fixed IS NU...

Classic

List

Threaded

26 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #2152: [CARBONDATA-2155][CARBONDATA-2152]Fixed IS NU...

GitHub user anubhav100 opened a pull request:

https://github.com/apache/carbondata/pull/2152

[CARBONDATA-2155][CARBONDATA-2152]Fixed IS NULL not working correctly on string datatype with dictionary include in presto

Fixed IS NULL not working correctly on string datatype with dictionary_include in presto integration
Fixed Min function working incorrectly for string type with dictionary include in presto integration

**Problem**:
1.When Creating SliceArrayBlock In CarbonDictionaryDeocdeReadSupport We are not inserting null values In SliceArrayBlock,Carbon Internaly represents Null Value in Dictionary As @NU#LL$! So When Creating SliceArrayBlock using dictionary chunk if we are getting the first chunk it will always be MEMBER_DEFAULT_VAL which is represented as @NU#LL$!,then we should add null
as value in our slicearrayblock

2.Our carbondatastore creator was not filling our dict value with @NU#LL$! in the first position of dict file

**Solution**:
1. When Creating SliceArrayBlock using dictionary chunk if we are getting the first chunk it will always be MEMBER_DEFAULT_VAL which is represented as @NU#LL$!,then we should add null

2. Refactored the CarbonDataStoreCreator Code to fill our dict value with @NU#LL$! in the
first position of dict file

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [ ] Any interfaces changed?

- [ ] Any backward compatibility impacted?

- [ ] Document update required?

- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?yes new test
cases are added
- How it is tested? Please attach test report.
testing is done manually
- Is it a performance related change? Please attach the performance test report
no.
- Any additional information to help reviewers in testing this change.

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-2155

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2152

----
commit 098c66856b8e1302fe07550f6a3c2a96de40c878
Author: anubhav100 <anubhav.tarar@...>
Date: 2018-04-09T12:45:31Z

Fixed IS NULL not working correctly on string datatype with dictionary_include in presto integration
Fixed Min function working incorrectly for string type with dictionary include in presto

Problem: 1.When Creating SliceArrayBlock In CarbonDictionaryDeocdeReadSupport We are not inserting null values In SliceArrayBlock,Carbon Internaly represents Null Value in Dictionary As @NU#LL$!
So When Creating SliceArrayBlock using dictionary chunk if we are getting the first chunk it will always be MEMBER_DEFAULT_VAL which is represented as @NU#LL$!,then we should add null
as value in our slicearrayblock

2.Our carbondatastore creator was not filling our dict value with @NU#LL$! in the first postion of dict file

Solution: 1. When Creating SliceArrayBlock using dictionary chunk if we are getting the first chunk it will always be MEMBER_DEFAULT_VAL which is represented as @NU#LL$!,then we should add null
as value in our slicearrayblock
2. Refactored the CarbonDataStoreCreator Code to fill our dict value with @NU#LL$! in the first postion of dict file

----

---

qiuchenjian-2