[GitHub] carbondata pull request #2164: [CARBONDATA-2327] [Presto] Fixed invalid sche...

[qiuchenjian-2]

GitHub user anubhav100 opened a pull request:

    https://github.com/apache/carbondata/pull/2164

    [CARBONDATA-2327] [Presto] Fixed invalid schema name _system shows when executed show schemas in presto

     Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-2327

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2164
   
----
commit de90b553ca9db5b8e1f61d16cd7d4d03bbf7586a
Author: anubhav100 <anubhav.tarar@...>
Date:   2018-04-12T06:16:37Z

    Fixed invalid schema name _system shows when executed show schemas in presto

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4958/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    @chenliang613 please review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4962/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4415/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4417/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4965/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4418/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    please consider CARBONDATA-2318 also.


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    @chenliang613 Hi Thnks, for issue CARBONDATA-2318 can you provide more steps to replicate the issue
    i tried on latest master but can't reproduce here are logs
   
     **./presto-cli-0.187-executable.jar --server localhost:9000 --catalog carbondata**
    **presto> show tables from default;**
            **Table**        
    **---------------------**
     **carbonsession_table**
    **(1 row)**
   
    **Query 20180412_152617_00000_y3hrj, FINISHED, 1 node**
    **Splits: 18 total, 18 done (100.00%)**
    **0:02 [1 rows, 36B] [0 rows/s, 23B/s]**
   



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5154/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3944/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5264/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4083/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5616/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4455/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2164
 
    My test result as below using this pull request.
   
   
    presto:default> show schemas;
           Schema
    --------------------
     .DS_Store
     default
     etc
     information_schema
     plugin
     var
    (6 rows)
   
    Query 20180514_051721_00003_9kcqn, FINISHED, 1 node
    Splits: 18 total, 18 done (100.00%)
    0:00 [6 rows, 76B] [23 rows/s, 299B/s]


---