[GitHub] carbondata pull request #2174: [CARBONDATA-2350][DataMap] Fix bugs in minmax...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2174

    [CARBONDATA-2350][DataMap] Fix bugs in minmax datamap example

    Fix bugs in minmax datamap example
   
    Previous implementation of minmax datamap example doesn't work as intended and has the following problems:
    + The example cannot run functionally.
    + The minmax datamap doesn't prune blocklet as intended.
    This PR fixed the above problems.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
     `NO`
     - [x] Document update required?
    `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `Updated the test case`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
    `NO`
            - Any additional information to help reviewers in testing this change.
          `NO`
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `Not related`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0416_minmax_dm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2174
   
----
commit 77a8b2114857914fd07f4df417b4c99d574abf7b
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-04-16T02:55:10Z

    Fix bugs in minmax datamap example
   
    Fix bugs in minmax datamap example

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2174
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3814/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2174
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5031/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2174#discussion_r181666508
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -445,6 +477,31 @@ private void putNull(int rowId) {
         }
       }
     
    +  /**
    +   * Get null at rowId
    +   */
    +  private Object getNull(int rowId) {
    --- End diff --
   
    It is not clear what this function return, can you add more description in comment


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2174#discussion_r181763328
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -445,6 +477,31 @@ private void putNull(int rowId) {
         }
       }
     
    +  /**
    +   * Get null at rowId
    +   */
    +  private Object getNull(int rowId) {
    --- End diff --
   
    This method is a supplement for the previous method `setNull`, since they are neighbours, I think it's not difficult to understand them at a time.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2174
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2174


---