[GitHub] carbondata pull request #2179: [WIP] Refactoring ReadCommittedStatus

[qiuchenjian-2]

GitHub user sounakr opened a pull request:

    https://github.com/apache/carbondata/pull/2179

    [WIP] Refactoring ReadCommittedStatus

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sounakr/incubator-carbondata unmanaged_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2179
   
----
commit 72f417584b10c2c948552896ad8e98f76257bd90
Author: sounakr <sounakr@...>
Date:   2018-04-18T03:38:27Z

    Refactoring ReadCommittedStatus

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3898/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5119/



---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5121/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3900/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r182389263
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -36,9 +39,23 @@
     
       private String segmentFileName;
     
    +  private ReadCommittedScope readCommittedScope;
    --- End diff --
   
    please provide comment for this variable


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r182390233
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId) {
         return new Segment(segmentId, null);
       }
     
    +  /**
    +   * SegmentId can be combination of segmentNo and segmentFileName
    +   * @param segmentId
    --- End diff --
   
    provide comment or remove it


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r182390285
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId) {
         return new Segment(segmentId, null);
       }
     
    +  /**
    +   * SegmentId can be combination of segmentNo and segmentFileName
    --- End diff --
   
    can you describe more what is in the SegmentId


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r182390577
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -36,9 +39,23 @@
     
       private String segmentFileName;
     
    +  private ReadCommittedScope readCommittedScope;
    +
       public Segment(String segmentNo, String segmentFileName) {
         this.segmentNo = segmentNo;
         this.segmentFileName = segmentFileName;
    +    this.readCommittedScope = null;
    +  }
    +
    +  public Segment(String segmentNo, String segmentFileName, ReadCommittedScope readCommittedScope) {
    +    this.segmentNo = segmentNo;
    +    this.segmentFileName = segmentFileName;
    +    this.readCommittedScope = readCommittedScope;
    +  }
    +
    +
    +  public Map<String, String> getCommittedIndexFile() throws IOException {
    --- End diff --
   
    add comment for this function, what is the return type (what map to what)


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5152/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3931/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3936/



---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4026/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2179
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5221/



---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r183069718
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -36,9 +39,23 @@
     
       private String segmentFileName;
     
    +  private ReadCommittedScope readCommittedScope;
    --- End diff --
   
    Done


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r183069772
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId) {
         return new Segment(segmentId, null);
       }
     
    +  /**
    +   * SegmentId can be combination of segmentNo and segmentFileName
    +   * @param segmentId
    --- End diff --
   
    Done


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r183069834
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId) {
         return new Segment(segmentId, null);
       }
     
    +  /**
    +   * SegmentId can be combination of segmentNo and segmentFileName
    --- End diff --
   
    Done


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r183069890
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -36,9 +39,23 @@
     
       private String segmentFileName;
     
    +  private ReadCommittedScope readCommittedScope;
    +
       public Segment(String segmentNo, String segmentFileName) {
         this.segmentNo = segmentNo;
         this.segmentFileName = segmentFileName;
    +    this.readCommittedScope = null;
    +  }
    +
    +  public Segment(String segmentNo, String segmentFileName, ReadCommittedScope readCommittedScope) {
    +    this.segmentNo = segmentNo;
    +    this.segmentFileName = segmentFileName;
    +    this.readCommittedScope = readCommittedScope;
    +  }
    +
    +
    +  public Map<String, String> getCommittedIndexFile() throws IOException {
    --- End diff --
   
    Done


---