[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT & SDV Testcases fo...

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2180#discussion_r184322994
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ColumnExpression.java ---
    @@ -132,5 +132,8 @@ public void setCarbonColumn(CarbonColumn carbonColumn) {
       public void findAndSetChild(Expression oldExpr, Expression newExpr) {
       }
     
    +  @Override public int getMaxDoc() {
    --- End diff --
   
    Don't add this method here, it is very specific to lucene. So only add this in that lucene expression.


---

[qiuchenjian-2]

Github user Indhumathi27 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2180#discussion_r184353464
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ColumnExpression.java ---
    @@ -132,5 +132,8 @@ public void setCarbonColumn(CarbonColumn carbonColumn) {
       public void findAndSetChild(Expression oldExpr, Expression newExpr) {
       }
     
    +  @Override public int getMaxDoc() {
    --- End diff --
   
    removed


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2180#discussion_r184357465
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala ---
    @@ -141,7 +141,9 @@ object CarbonFilters {
             case FalseExpr() =>
               Some(new FalseExpression(null))
             case TextMatch(queryString) =>
    -          Some(new MatchExpression(queryString))
    +          Some(new MatchExpression(queryString, null))
    +        case TextMatchDoc(queryString, maxDoc) =>
    --- End diff --
   
    please rename to TextMatchLimit


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2180#discussion_r184357724
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala ---
    @@ -536,6 +536,13 @@ private[sql] class CarbonLateDecodeStrategy extends SparkStrategy {
             }
             Some(TextMatch(u.children.head.toString()))
     
    +      case u: ScalaUDF if u.function.isInstanceOf[TextMatchMaxDocUDF] =>
    +        if (u.children.size > 2) {
    +          throw new MalformedCarbonCommandException(
    +            "TEXT_MATCH UDF syntax: TEXT_MATCH('luceneQuerySyntax')")
    --- End diff --
   
    This message is not correct, should be TEXT_MATCH_WITH_LIMIT


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2180#discussion_r184358059
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala ---
    @@ -536,6 +536,13 @@ private[sql] class CarbonLateDecodeStrategy extends SparkStrategy {
             }
             Some(TextMatch(u.children.head.toString()))
     
    +      case u: ScalaUDF if u.function.isInstanceOf[TextMatchMaxDocUDF] =>
    +        if (u.children.size > 2) {
    +          throw new MalformedCarbonCommandException(
    +            "TEXT_MATCH UDF syntax: TEXT_MATCH('luceneQuerySyntax')")
    +        }
    +        Some(TextMatchDoc(u.children.head.toString(), u.children.last.toString()))
    --- End diff --
   
    rename to TextMatchLimit


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5425/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4259/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4562/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4268/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4275/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5436/



---

[qiuchenjian-2]

Github user Indhumathi27 commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4283/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5449/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4566/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2180


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4571/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4581/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2180
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4583/



---