[GitHub] carbondata pull request #2189: [HOTFIX][branch-1.3] Add CarbonStreamingQuery...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/2189

    [HOTFIX][branch-1.3] Add CarbonStreamingQueryListener to SparkSession

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     
     - [x] Any backward compatibility impacted?
     no
     - [x] Document update required?
    no
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    small

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata streaming_listener_for_branch_1_3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2189
   
----
commit 0e42656837724052b0bfe057d3bd5a774c0098c7
Author: QiangCai <qiangcai@...>
Date:   2018-04-19T07:49:31Z

    add CarbonStreamingQueryListener to SparkSession

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2189#discussion_r182666461
 
    --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
    @@ -77,6 +78,22 @@ object StreamSinkFactory {
         }
       }
     
    +  lazy val listenerAdded = new mutable.HashMap[Int, Boolean]()
    +
    +  // add CarbonStreamingQueryListener to other SparkSession
    --- End diff --
   
    please change to `add CarbonStreamingQueryListener if it is SparkSession instance`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2189#discussion_r182666738
 
    --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
    @@ -77,6 +78,22 @@ object StreamSinkFactory {
         }
       }
     
    +  lazy val listenerAdded = new mutable.HashMap[Int, Boolean]()
    +
    +  // add CarbonStreamingQueryListener to other SparkSession
    +  def addListenerForSparkSession(sparkSession: SparkSession): Unit = {
    +    if (!"CarbonSession".equals(sparkSession.getClass.getSimpleName)) {
    --- End diff --
   
    move this function to createSink


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2189#discussion_r182675457
 
    --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
    @@ -77,6 +78,22 @@ object StreamSinkFactory {
         }
       }
     
    +  lazy val listenerAdded = new mutable.HashMap[Int, Boolean]()
    +
    +  // add CarbonStreamingQueryListener to other SparkSession
    +  def addListenerForSparkSession(sparkSession: SparkSession): Unit = {
    +    if (!"CarbonSession".equals(sparkSession.getClass.getSimpleName)) {
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2189
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2189
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5215/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2189
 
    @jackylk @QiangCai I raise a hotfix pr to fix import error after this pr was merged. The 'CarbonStreamingQueryListener' is in the package 'import org.apache.spark.sql.execution.streaming' on branch-1.3, not the package 'org.apache.carbondata.streaming'.


---

[qiuchenjian-2]

Github user QiangCai closed the pull request at:

    https://github.com/apache/carbondata/pull/2189


---