[GitHub] carbondata pull request #2190: [CARBONDATA-2359] Support applicable load opt...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2190
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5303/



---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2190#discussion_r183239131
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
    @@ -75,6 +78,11 @@ public TableSchemaBuilder tableName(String tableName) {
         return this;
       }
     
    +  public TableSchemaBuilder resetTransactionalTable(boolean isTransactionalTable) {
    --- End diff --
   
    change function name to setTransactionTable , there nothing resetting happening in this function


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2190#discussion_r183239308
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -210,11 +260,26 @@ private CarbonTable buildCarbonTable() {
           tableSchemaBuilder = tableSchemaBuilder.blockletSize(blockletSize);
         }
     
    -    List<String> sortColumnsList;
    -    if (sortColumns != null) {
    -      sortColumnsList = Arrays.asList(sortColumns);
    +    if (!isTransactionalTable) {
    --- End diff --
   
    always directly set value to tableSchemaBuilder


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2190#discussion_r183242493
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
    @@ -75,6 +78,11 @@ public TableSchemaBuilder tableName(String tableName) {
         return this;
       }
     
    +  public TableSchemaBuilder resetTransactionalTable(boolean isTransactionalTable) {
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2190#discussion_r183242496
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -210,11 +260,26 @@ private CarbonTable buildCarbonTable() {
           tableSchemaBuilder = tableSchemaBuilder.blockletSize(blockletSize);
         }
     
    -    List<String> sortColumnsList;
    -    if (sortColumns != null) {
    -      sortColumnsList = Arrays.asList(sortColumns);
    +    if (!isTransactionalTable) {
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2190
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2190
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4128/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2190
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5308/



---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2190#discussion_r183274384
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -123,6 +125,43 @@ public CarbonWriterBuilder uniqueIdentifier(long UUID) {
         return this;
       }
     
    +  /**
    +   * To support the load options for sdk writer
    +   * @param options key,value pair of load options.
    +   *                supported keys values are
    +   *                a. bad_records_logger_enable -- true, false
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/2190
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2190


---