[GitHub] carbondata pull request #2195: [CARBONDATA-2366] fixed concurrent datamap cr...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2195
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5543/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2195
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4380/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2195
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4639/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2195
 
    @kumarvishal09 build passed. Please review


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2195
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2195


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2195#discussion_r185715423
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/SearchModeTestCase.scala ---
    @@ -19,15 +19,17 @@ package org.apache.carbondata.spark.testsuite.detailquery
     
     import org.apache.spark.sql.test.util.QueryTest
     import org.apache.spark.sql.{CarbonSession, Row, SaveMode}
    -import org.scalatest.BeforeAndAfterAll
    -
    +import org.scalatest.{BeforeAndAfterAll, Ignore}
     import org.apache.carbondata.core.constants.CarbonCommonConstants
     import org.apache.carbondata.core.util.CarbonProperties
     import org.apache.carbondata.spark.util.DataGenerator
     
     /**
      * Test Suite for search mode
      */
    +
    +// TODO: Need to Fix
    +@Ignore
    --- End diff --
   
    Why ignore this test case? Are there any one to fix it now?


---