[GitHub] carbondata pull request #2214: [CARBONDATA-2387]Primitive AVRO Datatype Chec...

[qiuchenjian-2]

GitHub user sounakr opened a pull request:

    https://github.com/apache/carbondata/pull/2214

    [CARBONDATA-2387]Primitive AVRO Datatype Checking

    Test case added to check all the primitive datatype support of AVRO and its corresponding mapping with carbon datatypes.
   
     Supported Primitive Datatype.
         1. Boolean
         2. Int
         3. long
         4. float -> To carbon Internally it is double.
         5. double
         6. String
   
         Not Supported
         1.NULL Datatype
         2.Bytes
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sounakr/incubator-carbondata avro-primitive

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2214
   
----
commit 6db6739337c6a4fcbe3717abd72a5baab848ae0d
Author: sounakr <sounakr@...>
Date:   2018-04-23T11:56:03Z

    Primitive Avro Datatype Checking

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2214#discussion_r183374676
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ---
    @@ -85,11 +85,15 @@ private String avroFieldToString(Schema.Field fieldType, Object fieldValue) {
           case LONG:
           case DOUBLE:
           case STRING:
    +      case FLOAT:
             out.append(fieldValue.toString());
             break;
    +      case NULL:
    +        out.append("");
    --- End diff --
   
    In testcase it is saying NULL is not supported, but here it is ""?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2214
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4160/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2214
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4485/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2214
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5344/



---

[qiuchenjian-2]

Github user sounakr closed the pull request at:

    https://github.com/apache/carbondata/pull/2214


---