[GitHub] carbondata pull request #2221: [CARBONDATA-2392] Add close method for Carbon...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2221

    [CARBONDATA-2392] Add close method for CarbonReader

    CarbonReader haven't close method, it need about one miniute to stop when we invoke the carbonReader
   
    CarbonData should add the close method for CarbonReader.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2392-CarbonReaderClose

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2221
   
----
commit 8017455e9904314641c4cc938db7af6d578632f8
Author: xubo245 <601450868@...>
Date:   2018-04-24T09:59:42Z

    [CARBONDATA-2392] Add close method for CarbonReader

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4199/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4200/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4510/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5365/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4210/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5377/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    @jackylk @sraghunandan @ravipesala @QiangCai Please review it


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2221#discussion_r184027161
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderExample.java ---
    @@ -0,0 +1,80 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.sdk.file;
    +
    +import java.io.File;
    +import java.io.FilenameFilter;
    +import java.util.List;
    +
    +import org.apache.commons.io.FileUtils;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataTypes;
    +import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
    +
    +/**
    + * Example for testing CarbonReader
    + */
    +public class CarbonReaderExample {
    +    public static void main(String[] args) throws Exception {
    +        String path = "./testWriteFiles";
    +        FileUtils.deleteDirectory(new File(path));
    +
    +        Field[] fields = new Field[2];
    +        fields[0] = new Field("name", DataTypes.STRING);
    +        fields[1] = new Field("age", DataTypes.INT);
    +
    +        CarbonWriterBuilder builder = CarbonWriter.builder()
    +                .withSchema(new Schema(fields))
    +                .isTransactionalTable(true)
    +                .outputPath(path).persistSchemaFile(true);
    +
    +        CarbonWriter writer = builder.buildWriterForCSVInput();
    +
    +        for (int i = 0; i < 10; i++) {
    +            writer.write(new String[]{"robot" + (i % 10), String.valueOf(i)});
    +        }
    +        writer.close();
    +
    +        // Read schema in data file
    +        File[] dataFiles = new File(path + "/Fact/Part0/Segment_null/").listFiles(new FilenameFilter() {
    +            @Override
    +            public boolean accept(File dir, String name) {
    +                return name.endsWith("carbondata");
    +            }
    +        });
    +        List<ColumnSchema> columns = CarbonReader.readSchemaInDataFile(dataFiles[0].getAbsolutePath());
    +        System.out.println("Schema:");
    +        for (int i = 0; i < columns.size(); i++) {
    +            System.out.println(columns.get(i).getColumnName() + " " + columns.get(i).getDataType());
    +        }
    +
    +        // Read data
    +        CarbonReader reader = CarbonReader.builder(path, "_temp")
    --- End diff --
   
    Can carbon reader read from Non Transactional table?


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2221#discussion_r184284611
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderExample.java ---
    @@ -0,0 +1,80 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.sdk.file;
    +
    +import java.io.File;
    +import java.io.FilenameFilter;
    +import java.util.List;
    +
    +import org.apache.commons.io.FileUtils;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataTypes;
    +import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
    +
    +/**
    + * Example for testing CarbonReader
    + */
    +public class CarbonReaderExample {
    --- End diff --
   
    Either move this to examples or make this class as junit.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2221#discussion_r184308365
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderExample.java ---
    @@ -0,0 +1,80 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.sdk.file;
    +
    +import java.io.File;
    +import java.io.FilenameFilter;
    +import java.util.List;
    +
    +import org.apache.commons.io.FileUtils;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataTypes;
    +import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
    +
    +/**
    + * Example for testing CarbonReader
    + */
    +public class CarbonReaderExample {
    +    public static void main(String[] args) throws Exception {
    +        String path = "./testWriteFiles";
    +        FileUtils.deleteDirectory(new File(path));
    +
    +        Field[] fields = new Field[2];
    +        fields[0] = new Field("name", DataTypes.STRING);
    +        fields[1] = new Field("age", DataTypes.INT);
    +
    +        CarbonWriterBuilder builder = CarbonWriter.builder()
    +                .withSchema(new Schema(fields))
    +                .isTransactionalTable(true)
    +                .outputPath(path).persistSchemaFile(true);
    +
    +        CarbonWriter writer = builder.buildWriterForCSVInput();
    +
    +        for (int i = 0; i < 10; i++) {
    +            writer.write(new String[]{"robot" + (i % 10), String.valueOf(i)});
    +        }
    +        writer.close();
    +
    +        // Read schema in data file
    +        File[] dataFiles = new File(path + "/Fact/Part0/Segment_null/").listFiles(new FilenameFilter() {
    +            @Override
    +            public boolean accept(File dir, String name) {
    +                return name.endsWith("carbondata");
    +            }
    +        });
    +        List<ColumnSchema> columns = CarbonReader.readSchemaInDataFile(dataFiles[0].getAbsolutePath());
    +        System.out.println("Schema:");
    +        for (int i = 0; i < columns.size(); i++) {
    +            System.out.println(columns.get(i).getColumnName() + " " + columns.get(i).getDataType());
    +        }
    +
    +        // Read data
    +        CarbonReader reader = CarbonReader.builder(path, "_temp")
    --- End diff --
   
    No


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2221#discussion_r184310456
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderExample.java ---
    @@ -0,0 +1,80 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.sdk.file;
    +
    +import java.io.File;
    +import java.io.FilenameFilter;
    +import java.util.List;
    +
    +import org.apache.commons.io.FileUtils;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataTypes;
    +import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
    +
    +/**
    + * Example for testing CarbonReader
    + */
    +public class CarbonReaderExample {
    --- End diff --
   
    ok, done,  move this to the examples.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4247/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4553/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5415/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4281/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5447/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2221
 
    @ravipesala CI pass.


---