[GitHub] carbondata pull request #2229: [HOTFIX] Remove carbon-spark2 dependency in c...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2229

    [HOTFIX] Remove carbon-spark2 dependency in carbon-bloom

    carbon-bloom module should not depend on carbon-spark2 module.
    Moved testcase to spark2 module and add carbon-bloom dependency in carbon-spark2 pom for test scope.
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
     NA
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata bloom-dep

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2229
   
----
commit c1de825a6a0ff220c657e2ff73c60e72953567d3
Author: Jacky Li <jacky.likun@...>
Date:   2018-04-26T06:31:09Z

    remove spark2 dependency in bloom

----


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    Spark2 or Spark-Common-Test, which is better for the testsuite?


---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    please remove carbon-spark2 dependency from carbon-lucene


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4548/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4243/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5410/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4549/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2229


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2229
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4567/



---