[GitHub] carbondata pull request #2232: [CARBONDATA-2406][dataload]-Dictionary Server...

[qiuchenjian-2]

GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/carbondata/pull/2232

    [CARBONDATA-2406][dataload]-Dictionary Server and Dictionary Client MD5 Validation failed with hive.server2.enable.doAs = true

    With conf hive.server2.enable.doAs = true, the dictionary server is started with the user who submit the load request. But the dictionary client run as the user who started the executor process. Due to this dictionary client can not successfully communicate with the dictionary server.
   
     - [X] Any interfaces changed?
     None
     - [X] Any backward compatibility impacted?
     None
     - [X] Document update required?
    None
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           No test case added.
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata dictionary_server

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2232
   
----
commit afb9f0826b415c75fc5b3b67b17b3583132e00e5
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date:   2018-04-26T11:02:21Z

    [CARBONDATA-2406][dataload]-Dictionary Server and Dictionary Client MD5 Validation failed with hive.server2.enable.doAs = true

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4255/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5428/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4563/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2232#discussion_r185400079
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/dictionary/server/SecureDictionaryServer.java ---
    @@ -63,7 +67,18 @@ private SecureDictionaryServer(SparkConf conf, String host, int port) {
         this.conf = conf;
         this.host = host;
         this.port = port;
    -    startServer();
    +    try {
    +      UserGroupInformation.getLoginUser().doAs(new PrivilegedExceptionAction<Void>() {
    +        @Override public Void run() throws Exception {
    +          startServer();
    +          return null;
    +        }
    +      });
    +    } catch (IOException io) {
    +      LOGGER.error(io, "Failed to Dictionary Server server in secure mode");
    +    } catch (InterruptedException ie) {
    +      LOGGER.error(ie, "Failed to Dictionary Server server in secure mode");
    --- End diff --
   
    Correct the error message in both the catch blocks
    "Failed to start Dictionary Server in secure mode"


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2232#discussion_r185411161
 
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/dictionary/server/SecureDictionaryServer.java ---
    @@ -63,7 +67,18 @@ private SecureDictionaryServer(SparkConf conf, String host, int port) {
         this.conf = conf;
         this.host = host;
         this.port = port;
    -    startServer();
    +    try {
    +      UserGroupInformation.getLoginUser().doAs(new PrivilegedExceptionAction<Void>() {
    +        @Override public Void run() throws Exception {
    +          startServer();
    +          return null;
    +        }
    +      });
    +    } catch (IOException io) {
    +      LOGGER.error(io, "Failed to Dictionary Server server in secure mode");
    +    } catch (InterruptedException ie) {
    +      LOGGER.error(ie, "Failed to Dictionary Server server in secure mode");
    --- End diff --
   
    corrected the message


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4414/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5575/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2232


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4418/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5580/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4669/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2232
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4672/



---