[GitHub] carbondata pull request #2235: [WIP]Make default replication as 3 for direct...

[qiuchenjian-2]

GitHub user KanakaKumar opened a pull request:

    https://github.com/apache/carbondata/pull/2235

    [WIP]Make default replication as 3 for direct write HDFS mode

            Problem:
            At present if we enable direct write on HDFS, data is written with replication of 1 which can cause dataloss.
            Solution: Use default replication as 3 and also make it configurable so that user can tune based on the need
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KanakaKumar/carbondata directHDFSWriteFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2235
   
----
commit 4da3a13c2ae0d2193572affbf9a52aabcf14820c
Author: KanakaKumar <kanaka.avvau@...>
Date:   2018-04-26T18:09:29Z

    Make default replication as 3 for direct write HDFS mode
   
            Problem:
            At present if we enable direct write on HDFS, data is written with replication of 1 which can cause dataloss.
            Solution: Use default replication as 3 and also make it configurable so that user can tune based on the need

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4276/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5439/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    There is no need to add a property for the default replicator. We can read it from HDFS system property.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4584/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4585/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5759/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4819/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4601/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2235#discussion_r187216778
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
    @@ -152,6 +152,9 @@
        */
       private boolean enableDirectlyWriteData2Hdfs = false;
     
    +  // Initially write 3 replicas and set the cluster configured replication once file write finished
    +  private short initialWriteReplication = 3;
    --- End diff --
   
    please get the initial replication from hdfs default, like below
    ```
    short replication = FileFactory.getDefaultReplication(fileName, fileType);
    ``
   
    We only need to modify Line361, use this value to replace 1.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4882/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4678/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5834/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    The changes are OK, better to correct the title of commit


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5939/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4784/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2235


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2235
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4970/



---