[GitHub] carbondata pull request #2242: [HOTFIX] Carbon should throw exception for TE...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2242

    [HOTFIX] Carbon should throw exception for TEXT_MATCH UDF

    Carbon should throw exception for TEXT_MATCH UDF on a table that does not have a lucene datamap
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
     Test added      
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata fix-text-match

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2242
   
----

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4307/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5474/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2242#discussion_r184841885
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java ---
    @@ -193,7 +193,9 @@ private void initMeasureChunkIndexes() {
       public BitSetGroup applyFilter(RawBlockletColumnChunks rawBlockletColumnChunks,
           boolean useBitsetPipeLine) throws FilterUnsupportedException, IOException {
         if (exp instanceof MatchExpression) {
    -      return rawBlockletColumnChunks.getBitSetGroup();
    +      // if there are datamap created on this table, it should not come to here
    +      throw new FilterUnsupportedException(
    +          exp.getFilterExpressionType().name() + " is not supported on this table");
    --- End diff --
   
    Won't it be better to add tableName information to the error message, such as
    ```
    ... is not supported on $dbName.$tableName
    ```


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2242#discussion_r184857788
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java ---
    @@ -193,7 +193,9 @@ private void initMeasureChunkIndexes() {
       public BitSetGroup applyFilter(RawBlockletColumnChunks rawBlockletColumnChunks,
           boolean useBitsetPipeLine) throws FilterUnsupportedException, IOException {
         if (exp instanceof MatchExpression) {
    -      return rawBlockletColumnChunks.getBitSetGroup();
    +      // if there are datamap created on this table, it should not come to here
    +      throw new FilterUnsupportedException(
    +          exp.getFilterExpressionType().name() + " is not supported on this table");
    --- End diff --
   
    ok. fixed


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2242#discussion_r184857799
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java ---
    @@ -193,7 +193,9 @@ private void initMeasureChunkIndexes() {
       public BitSetGroup applyFilter(RawBlockletColumnChunks rawBlockletColumnChunks,
           boolean useBitsetPipeLine) throws FilterUnsupportedException, IOException {
         if (exp instanceof MatchExpression) {
    -      return rawBlockletColumnChunks.getBitSetGroup();
    +      // if there are datamap created on this table, it should not come to here
    +      throw new FilterUnsupportedException(
    +          exp.getFilterExpressionType().name() + " is not supported on this table");
    --- End diff --
   
    not yet, need to add doc


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5509/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4344/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4612/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4443/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5604/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4697/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5624/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4464/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4717/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4476/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5636/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4742/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2242
 
    LGTM


---