[GitHub] carbondata pull request #2253: [CARBONDATA-2421] Remove unused code of Carbo...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2253: [CARBONDATA-2421] Remove unused code of Carbo...

qiuchenjian-2
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2253

    [CARBONDATA-2421] Remove unused code of CarbonGetTableDetailCommand

    CarbonGetTableDetailCommand is unused by any other class or method, better to remove it as well as the related tests.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
     `NO`
     - [x] Document update required?
    `NO`
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `Removed tests`
            - How it is tested? Please attach test report.
    `Tested in local`
            - Is it a performance related change? Please attach the performance test report.
    `NA`
            - Any additional information to help reviewers in testing this change.
           `NA`
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0501_remove_CarbonGetTableCmd

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2253
   
----
commit 0ba4180cabcab753c3422701da77f48d42da4e03
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-05-01T04:30:41Z

    Remove unused code of CarbonGetTableDetailCommand

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2253: [CARBONDATA-2421] Remove unused code of CarbonGetTab...

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2253
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4645/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2253: [CARBONDATA-2421] Remove unused code of CarbonGetTab...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2253
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5549/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2253: [CARBONDATA-2421] Remove unused code of CarbonGetTab...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2253
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4386/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2253: [CARBONDATA-2421] Remove unused code of Carbo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/2253


---