[GitHub] carbondata pull request #2254: [CARBONDATA-2415] Support Refresh DataMap com...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2254
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2254


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2254#discussion_r189503091
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/FGDataMapTestCase.scala ---
    @@ -413,7 +409,7 @@ class FGDataMapWriter(identifier: AbsoluteTableIdentifier,
         stream.write(bytes)
         stream.writeInt(bytes.length)
         stream.close()
    -    commitFile(fgwritepath + "/"+taskName)
    +//    commitFile(fgwritepath)
    --- End diff --
   
    Why keep this line?


---