[GitHub] carbondata pull request #2262: [CARBONDATA-2431] Incremental data added afte...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2262
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4672/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2262
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5828/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2262#discussion_r187553518
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/TableStatusReadCommittedScope.java ---
    @@ -37,6 +39,7 @@
     public class TableStatusReadCommittedScope implements ReadCommittedScope {
     
       private LoadMetadataDetails[] loadMetadataDetails;
    +  UpdateVO updateVo;
    --- End diff --
   
    Make it private


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2262#discussion_r187554854
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/TableStatusReadCommittedScope.java ---
    @@ -77,6 +84,17 @@ public TableStatusReadCommittedScope(AbsoluteTableIdentifier identifier,
         return indexFiles;
       }
     
    +  public SegmentRefreshInfo getCommitedSegmentRefreshInfo(Segment segment)
    +      throws IOException {
    +    SegmentRefreshInfo segmentRefreshInfo;
    +    if (updateVo != null) {
    +      segmentRefreshInfo = new SegmentRefreshInfo(updateVo.getCreatedOrUpdatedTimeStamp(), 0);
    +    } else {
    +      segmentRefreshInfo = new SegmentRefreshInfo(0L, 0);
    +    }
    +    return segmentRefreshInfo;
    +  }
    +
    --- End diff --
   
    Add setter of CommitedSegmentRefreshInfo and set it.


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2262#discussion_r187555918
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/TableStatusReadCommittedScope.java ---
    @@ -77,6 +84,17 @@ public TableStatusReadCommittedScope(AbsoluteTableIdentifier identifier,
         return indexFiles;
       }
     
    +  public SegmentRefreshInfo getCommitedSegmentRefreshInfo(Segment segment)
    --- End diff --
   
    Add another argument to pass UpdateVo


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2262
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4680/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2262
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5836/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2262
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4884/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2262
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2262


---