[GitHub] carbondata pull request #2271: [CARBONDATA-2439][Pom] upgrade guava version ...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2271: [CARBONDATA-2439][Pom] upgrade guava version ...

qiuchenjian-2
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2271

    [CARBONDATA-2439][Pom] upgrade guava version for bloom datamap

    upgrade guava version from 11.0.2(provided by hadoop) to 14.0.1(provided by spark)
   
    The dependency scope in carbon-bloom is `compile`, because `provide` scope will cause Class/MethodNotFound failure during tests. But never mind, we remove the guava dependency in carbon-assembly.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     `NA`
     - [ ] Any backward compatibility impacted?
     `NA`
     - [ ] Document update required?
     `NA`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
     `NA`
            - How it is tested? Please attach test report.
     `NA`
            - Is it a performance related change? Please attach the performance test report.
     `NA`
            - Any additional information to help reviewers in testing this change.
     `NA`
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
     `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0504_upgrade_guava_bloom

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2271
   
----
commit 37bab5e5c3ff788b730599935a0735d3db713214
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-05-04T13:52:16Z

    upgrade guava version for bloom datamap
   
    upgrade guava version from 11.0.2(provided by hadoop) to 14.0.1(provided by spark)

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2271: [CARBONDATA-2439][Pom] upgrade guava version for blo...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2271
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5652/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2271: [CARBONDATA-2439][Pom] upgrade guava version for blo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2271
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4492/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2271: [CARBONDATA-2439][Pom] upgrade guava version for blo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2271
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4729/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2271: [CARBONDATA-2439][Pom] upgrade guava version for blo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2271
 
    Will you modify the BloomDataMap to use the latest API also?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2271: [CARBONDATA-2439][Pom] upgrade guava version for blo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2271
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2271: [CARBONDATA-2439][Pom] upgrade guava version ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2271


---