[GitHub] carbondata pull request #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDA...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5763/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4604/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4612/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4824/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5771/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4617/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2278#discussion_r187127815
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/csvinput/CSVInputFormat.java ---
    @@ -281,6 +281,7 @@ public void initialize(InputSplit inputSplit, TaskAttemptContext context)
               Charset.forName(CarbonCommonConstants.DEFAULT_CHARSET));
     
           CsvParserSettings settings = extractCsvParserSettings(job);
    +      settings.setReadInputOnSeparateThread(false);
    --- End diff --
   
    Why this change is required??


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2278#discussion_r187128530
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -468,6 +483,13 @@ private void buildTableSchema(Field[] fields, TableSchemaBuilder tableSchemaBuil
         }
       }
     
    +  private void isDataTypeSupportedForCarbonWriter(DataType dataType) {
    --- End diff --
   
    Change this method name as these data type is not supported for complex data type's children column


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4620/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5778/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4623/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4833/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4834/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4840/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5787/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4632/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2278#discussion_r187260152
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/csvinput/CSVInputFormat.java ---
    @@ -281,6 +281,7 @@ public void initialize(InputSplit inputSplit, TaskAttemptContext context)
               Charset.forName(CarbonCommonConstants.DEFAULT_CHARSET));
     
           CsvParserSettings settings = extractCsvParserSettings(job);
    +      settings.setReadInputOnSeparateThread(false);
    --- End diff --
   
    This will hit data loading performance, it think better to expose one property with default value true, if user don't want in in different thread he can set this to false.
    I think this change is not related to Complex type please raise in separate PR


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2278
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5792/



---