[GitHub] carbondata pull request #2293: [CARBONDATA-2468] addition of default sort_co...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/2293

    [CARBONDATA-2468] addition of default sort_column handled

    **issue :** default sort_column handling was missing
    **solution :**  condition added for default sort_columns
   
     - [ ] Any interfaces changed? NO
     
     - [ ] Any backward compatibility impacted?No
     
     - [ ] Document update required?NO
   
     - [ ] Testing done==> UT added
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-2468

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2293
   
----
commit 33985d350001b8b8d4cd4bf1d79405c934bcc824
Author: rahulforallp <rahul.kumar@...>
Date:   2018-05-10T10:47:39Z

    addition of default sort_column handled

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4646/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5801/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4854/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2293#discussion_r187530228
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -481,9 +482,13 @@ private void buildTableSchema(Field[] fields, TableSchemaBuilder tableSchemaBuil
               ColumnSchema columnSchema = tableSchemaBuilder
                   .addColumn(new StructField(field.getFieldName(), field.getDataType()),
                       valIndex, isSortColumn > -1);
    -          columnSchema.setSortColumn(true);
               if (isSortColumn > -1) {
    +            columnSchema.setSortColumn(true);
                 sortColumnsSchemaList[isSortColumn] = columnSchema;
    +          } else if (sortColumnsList.isEmpty() && columnSchema.isDimensionColumn()) {
    --- End diff --
   
    Complex column and it's children should not be considered as sort column, please handle the same


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4877/



---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2293#discussion_r187533373
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -481,9 +482,13 @@ private void buildTableSchema(Field[] fields, TableSchemaBuilder tableSchemaBuil
               ColumnSchema columnSchema = tableSchemaBuilder
                   .addColumn(new StructField(field.getFieldName(), field.getDataType()),
                       valIndex, isSortColumn > -1);
    -          columnSchema.setSortColumn(true);
               if (isSortColumn > -1) {
    +            columnSchema.setSortColumn(true);
                 sortColumnsSchemaList[isSortColumn] = columnSchema;
    +          } else if (sortColumnsList.isEmpty() && columnSchema.isDimensionColumn()) {
    --- End diff --
   
    complex check is already handled above.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5830/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4878/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4675/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Please fix the build


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4687/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5843/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4889/



---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4704/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5858/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2293
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2293


---