[GitHub] carbondata pull request #2297: [CARBONDATA-2471]Added support for No Diction...

[qiuchenjian-2]

GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/2297

    [CARBONDATA-2471]Added support for No Dictionary Complex type for Double, Decimal, Date type in SDK

    Added support for No Dictionary Complex type for Double, Decimal, Date type in SDK
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
           Added UT for each data type
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata nodicdouble

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2297
   
----
commit 46a37226356d3cc619317b633d13d396016a4a6d
Author: kunal642 <kunalkapoor642@...>
Date:   2018-05-07T15:28:21Z

    fixed issues related to complex types

commit 57b7ad8f8ac55cd2b027a26de9cf6df9ca855301
Author: kumarvishal09 <kumarvishal1802@...>
Date:   2018-05-10T17:22:09Z

    added support for Double, Decimal, date data type in No Dictionary Complex type

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4662/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5818/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5824/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4668/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4869/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4676/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5831/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2297#discussion_r187539412
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java ---
    @@ -46,6 +49,8 @@
     
       private boolean isDictionary;
     
    +  private DirectDictionaryGenerator directDictionaryGenerator;
    --- End diff --
   
    change name to `directDictGenForDate`


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4879/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2297#discussion_r187551083
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -331,6 +331,10 @@ public static Object getDataBasedOnDataType(String data, DataType actualDataType
           return ByteUtil.toBytes(Integer.parseInt(dimensionValue));
         } else if (actualDataType == DataTypes.LONG) {
           return ByteUtil.toBytes(Long.parseLong(dimensionValue));
    +    } else if (actualDataType == DataTypes.DOUBLE) {
    +      return ByteUtil.toBytes(Double.doubleToLongBits(Double.parseDouble(dimensionValue)));
    --- End diff --
   
    Add methods in ByteUtil to convert from double to byte array and byte array to double instead of handling here


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2297#discussion_r187551301
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -449,6 +457,16 @@ public static Object getDataBasedOnDataTypeForNoDictionaryColumn(byte[] dataInBy
               return null;
             }
             return ByteUtil.toLong(dataInBytes, 0, dataInBytes.length) * 1000L;
    +      } else if (actualDataType == DataTypes.DOUBLE) {
    +        if (isEmptyByteArray(dataInBytes)) {
    +          return null;
    +        }
    +        return Double.longBitsToDouble(ByteUtil.toLong(dataInBytes, 0, dataInBytes.length));
    --- End diff --
   
    Move to ByteUtil


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2297#discussion_r187551542
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
    @@ -393,13 +393,6 @@ class TableNewProcessor(cm: TableModel) {
         var allColumns: Seq[ColumnSchema] = Seq[ColumnSchema]()
         fieldChildren.foreach(fields => {
           fields.foreach(field => {
    -        if (!useDictionaryEncoding &&
    --- End diff --
   
    Don't remove this check in normal flow.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4880/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2297#discussion_r187555180
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
    @@ -393,13 +393,6 @@ class TableNewProcessor(cm: TableModel) {
         var allColumns: Seq[ColumnSchema] = Seq[ColumnSchema]()
         fieldChildren.foreach(fields => {
           fields.foreach(field => {
    -        if (!useDictionaryEncoding &&
    --- End diff --
   
    This was added to block double/date/decimal for complex type in case of dictionary exclude as now it is supported remove the same. this check is only applicable for complex type children


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4881/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5832/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4677/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2297
 
    LGTM


---