GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2303 [CARBONDATA-2476][DataMap] Fix bug in bloom datamap cache
Since the cache is used by all bloomfilter datamaps, the cache will be evicted only for specified keys only if loading the specified cache is failed.
Previous bug will cause all the cache be evicted after it is loaded.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`NO`
- How it is tested? Please attach test report.
`Tested in local`
- Is it a performance related change? Please attach the performance test report.
`After this PR, performance is as we expected`
- Any additional information to help reviewers in testing this change.
`NO`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`NO`
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/xuchuanyin/carbondata 0514_bug_bloom_cache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2303.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2303
----
commit 388d1142a0fcefed569dbbace6b8472bae142782
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-05-14T02:46:33Z
Fix bug in bloom datamap cache
Since the cache is used by all bloomfilter datamaps, the cache will be evicted only for specified keys only if loading the specified cache is failed.
----
---
Locked
