[GitHub] carbondata pull request #2304: Fixed No dictionary Complex type with double/...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5900/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4746/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4748/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5902/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5903/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4749/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4934/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5904/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4750/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4936/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4937/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4938/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2304#discussion_r188885269
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -202,9 +249,36 @@ private static ColumnPage getLVBytesColumnPage(TableSpec.ColumnSpec columnSpec,
         lvEncodedOffset = 0;
         for (int i = 0; i < numRows; i++) {
           length = rowLength.get(i);
    -      page.putBytes(i, lvEncodedBytes, lvEncodedOffset + 4, length);
    -      lvEncodedOffset += 4 + length;
    +      page.putBytes(i, lvEncodedBytes, lvEncodedOffset + lvLength, length);
    +      lvEncodedOffset += lvLength + length;
         }
    +    return page;
    +  }
    +
    +  private static ColumnPage getComplexParentBytesColumnPage(TableSpec.ColumnSpec columnSpec,
    --- End diff --
   
    Check and remove if not required


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2304#discussion_r188885431
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -353,6 +427,32 @@ public double getDouble(int rowId) {
         return data;
       }
     
    +  @Override public byte[] getComplexChildrenLVFlattenedBytePage() throws IOException {
    +    // output LV encoded byte array
    +    int offset = 0;
    +    byte[] data = new byte[totalLength + pageSize * 2];
    +    for (int rowId = 0; rowId < pageSize; rowId++) {
    +      short length = (short) (rowOffset[rowId + 1] - rowOffset[rowId]);
    +      ByteUtil.setShort(data, offset, length);
    +      copyBytes(rowId, data, offset + 2, length);
    +      offset += 2 + length;
    +    }
    +    return data;
    +  }
    +
    +  @Override
    +  public byte[] getComplexParentFlattenedBytePage() throws IOException {
    --- End diff --
   
    Check and remove if not required


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4781/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5936/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4966/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2304
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2304


---