[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...

[qiuchenjian-2]

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2306
 
    @ravipesala : PR is ready


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2306#discussion_r188838995
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -540,4 +543,19 @@ private CarbonLoadModel buildLoadModel(CarbonTable table, long UUID, String task
         setCsvHeader(build);
         return build;
       }
    +
    +  /**
    +   * can set the sortScope to NO_SORT
    +   *
    +   * @param sortScope can be set to "NO_SORT" to avoid sorting during load.
    +   * by default sort_scope is "LOCAL_SORT"
    +   * @return updated CarbonWriterBuilder
    +   */
    +  public CarbonWriterBuilder sortScope(String sortScope) {
    +    if (!sortScope.equalsIgnoreCase("NO_SORT")) {
    --- End diff --
   
    Removed it and also avro Timestamp issue


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2306
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2306


---