[GitHub] carbondata pull request #2316: [WIP] Removed method to accept carbon schema ...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5991/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4833/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5011/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4836/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5996/



---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2316#discussion_r189530705
 
    --- Diff: docs/sdk-writer-guide.md ---
    @@ -33,9 +33,9 @@ These SDK writer output contains just a carbondata and carbonindex files. No met
     
          Schema schema = new Schema(fields);
     
    -     CarbonWriterBuilder builder = CarbonWriter.builder().withSchema(schema).outputPath(path);
    --- End diff --
   
    done


---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2316#discussion_r189530725
 
    --- Diff: docs/sdk-writer-guide.md ---
    @@ -93,9 +93,8 @@ public class TestSdkAvro {
     
         try {
           CarbonWriter writer = CarbonWriter.builder()
    -          .withSchema(carbonSchema)
               .outputPath(path)
    -          .buildWriterForAvroInput();
    +          .buildWriterForAvroInput(new org.apache.avro.Schema.Parser().parse(avroSchema));
    --- End diff --
   
    removed


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5015/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6001/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2316


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2316
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4842/



---