[GitHub] carbondata pull request #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Time...

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2334#discussion_r197721852
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java ---
    @@ -171,134 +170,89 @@ else if (colType.equals(DecimalType.createDecimalType(carbondataColumnHandle.get
        * @return
        */
       static Expression parseFilterExpression(TupleDomain<ColumnHandle> originalConstraint) {
    -    ImmutableList.Builder<Expression> filters = ImmutableList.builder();
     
         Domain domain;
    +    Expression finalFilters = null;
    --- End diff --
   
    1. I mean, please put these detail explanation inside the code in your pr
    2. colExpression, just column's name and data type, why may change ?



---

[qiuchenjian-2]

Github user sv71294 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2334#discussion_r197722635
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java ---
    @@ -171,134 +170,89 @@ else if (colType.equals(DecimalType.createDecimalType(carbondataColumnHandle.get
        * @return
        */
       static Expression parseFilterExpression(TupleDomain<ColumnHandle> originalConstraint) {
    -    ImmutableList.Builder<Expression> filters = ImmutableList.builder();
     
         Domain domain;
    +    Expression finalFilters = null;
    --- End diff --
   
    sure, adding comments in code


---

[qiuchenjian-2]

Github user sv71294 commented on the issue:

    https://github.com/apache/carbondata/pull/2334
 
    @chenliang613 I have added the comments in the code, please review it now.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2334
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6526/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2334
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5358/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2334


---