[GitHub] carbondata pull request #2335: [WIP] integrate carbonstore mv branch

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2335
 
    @eychih The code added to rewrite with MV table is done outside so there would not be any harm to the purpose of MV. And moreover checking the sameresult multiple times gives performance problems while doing matching. And we have tested the sameresult and gives the problem if the session changes unless we maintain the cache for each session, I think that is not a good idea.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2335
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2335


---

[qiuchenjian-2]

Github user eychih commented on the issue:

    https://github.com/apache/carbondata/pull/2335
 
    @ravipesala @jackylk It looks like the discussion become uninteresting and unproductive now.  I just try to make some constructive comments.  The comments I made in the previous discussions remain true.  In terms of MV, the performance bottleneck comes from the amount of data we need to process and how we process them, e.g. using cache, rather than matching time of the logical plan.  The reason I take the approach in chowbranch because the old code is difficult to understand and to extend.  This is not just my opinion.  I will stop here and not make any further comment.  



---