[GitHub] carbondata pull request #2336: [CARBONDATA-2521] Support create carbonReader...

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    @jackylk CI pass， please review again


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2336#discussion_r191825493
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
    @@ -88,6 +90,20 @@ public static CarbonReaderBuilder builder(String tablePath, String tableName) {
         return new CarbonReaderBuilder(tablePath, tableName);
       }
     
    +  /**
    +   * Return a new {@link CarbonReaderBuilder} instance
    +   * Default value of table name is table + time
    +   *
    +   * @param tablePath table path
    +   * @return CarbonReaderBuilder object
    +   */
    +  public static CarbonReaderBuilder builder(String tablePath) {
    +    String time = new SimpleDateFormat("yyyyMMddHHmmssSSS").format(new Date());
    +    String uniqueName = "table" + time;
    --- End diff --
   
    can you get the substring of `tablePath` and append with time


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2336#discussion_r191973756
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
    @@ -88,6 +90,20 @@ public static CarbonReaderBuilder builder(String tablePath, String tableName) {
         return new CarbonReaderBuilder(tablePath, tableName);
       }
     
    +  /**
    +   * Return a new {@link CarbonReaderBuilder} instance
    +   * Default value of table name is table + time
    +   *
    +   * @param tablePath table path
    +   * @return CarbonReaderBuilder object
    +   */
    +  public static CarbonReaderBuilder builder(String tablePath) {
    +    String time = new SimpleDateFormat("yyyyMMddHHmmssSSS").format(new Date());
    +    String uniqueName = "table" + time;
    --- End diff --
   
    ok, I add a convert method for it.
   
    "./testWriteFiles/" => "table_testWriteFiles_20180531101931973"
    "hdfs://testWriteFiles/" =>"table_hdfs_testWriteFiles_20180531102022516"
    "s3a://sdk/ => "table_s3a_sdk_20180531102058551"



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6192/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5031/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5166/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2336#discussion_r191982770
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -631,6 +631,29 @@ public static int nextGreaterValueToTarget(int currentIndex,
         return integers;
       }
     
    +  /**
    +   * Convert path with start and end string
    +   * Convert / . \ : space to _
    +   * remove duplicate _
    +   *
    +   * @param path   store path
    +   * @param prefix prefix string
    +   * @param suffix suffix string
    +   * @return converted string
    +   */
    +  public static String convertPath(String path, String prefix, String suffix) {
    --- End diff --
   
    please add UT for this func


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6193/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5032/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5167/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2336#discussion_r191985122
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -631,6 +631,29 @@ public static int nextGreaterValueToTarget(int currentIndex,
         return integers;
       }
     
    +  /**
    +   * Convert path with start and end string
    +   * Convert / . \ : space to _
    +   * remove duplicate _
    +   *
    +   * @param path   store path
    +   * @param prefix prefix string
    +   * @param suffix suffix string
    +   * @return converted string
    +   */
    +  public static String convertPath(String path, String prefix, String suffix) {
    --- End diff --
   
    remove this one and change the table name to UnknownTable+time


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5034/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6197/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5036/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5169/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2336


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5171/



---