[GitHub] carbondata pull request #2338: [CARBONDATA-2524] Support create carbonReader...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4952/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    @sounakr Done, CI pass.


---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    LGTM


---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2338#discussion_r191174415
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java ---
    @@ -61,6 +64,33 @@ public CarbonReaderBuilder projection(String[] projectionColumnNames) {
         return this;
       }
     
    +  /**
    +   * All Columns need to be Projected
    +   *
    +   * @return CarbonReaderBuilder object
    +   * @throws IOException
    +   */
    +  public CarbonReaderBuilder projectAllColumns() throws IOException {
    --- End diff --
   
    can you add a description for this method in reader document


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2338#discussion_r191176382
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java ---
    @@ -61,6 +64,33 @@ public CarbonReaderBuilder projection(String[] projectionColumnNames) {
         return this;
       }
     
    +  /**
    +   * All Columns need to be Projected
    +   *
    +   * @return CarbonReaderBuilder object
    +   * @throws IOException
    +   */
    +  public CarbonReaderBuilder projectAllColumns() throws IOException {
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6130/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4968/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6135/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2338


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4971/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5119/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5120/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2338
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5123/



---