[GitHub] carbondata pull request #2340: [CARBONDATA-2529] Fixed S3 Issue for Hadoop 2...

[qiuchenjian-2]

GitHub user bhavya411 opened a pull request:

    https://github.com/apache/carbondata/pull/2340

    [CARBONDATA-2529] Fixed S3 Issue for Hadoop 2.8.3

    This issue fixes the issue while loading the data with S3 as backend.
   
     - [ N] Any interfaces changed?
     
     - [N ] Any backward compatibility impacted?
     
     - [ N] Document update required?
   
     - [Y ] Testing done
   
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-2529

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2340
   
----
commit a05a7db79c5d1e25fc78b65f07b5f5fedc8611de
Author: Bhavya <bhavya@...>
Date:   2018-05-24T15:47:58Z

    Fixed S3 Issue for Hadoop 2.8.3

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2340
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6099/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2340
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4937/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2340
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5093/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2340
 
    LGTM.  is there any other URI for object storage?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2340#discussion_r191330412
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/HDFSCarbonFile.java ---
    @@ -120,7 +120,8 @@ public boolean renameForce(String changetoName) {
             ((DistributedFileSystem) fs).rename(fileStatus.getPath(), new Path(changetoName),
                 org.apache.hadoop.fs.Options.Rename.OVERWRITE);
             return true;
    -      } else if (fileStatus.getPath().toString().startsWith("s3n")) {
    +      } else if (fileStatus.getPath().toString().startsWith("s3n") || fileStatus.getPath()
    --- End diff --
   
    move `fileStatus.getPath()` to next line


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2340
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5043/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2340
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6206/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2340
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5179/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2340


---