[GitHub] carbondata pull request #2344: [CARBONDATA-2538] added filter while listing ...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/2344

    [CARBONDATA-2538] added filter while listing files from writer path

    1. Added filter to list only index and carbondata files. So even if the lock files are present proper exception can be thrown
    2. Updated complex type docs
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata sdk_snapshot

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2344
   
----
commit b362802e14dbcaefdc130288f9e88ba2f874c09d
Author: kunal642 <kunalkapoor642@...>
Date:   2018-05-25T10:51:45Z

    added filter while listing files from writer path

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6106/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4944/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5100/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6117/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4955/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2344#discussion_r191122822
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -892,7 +894,22 @@ public boolean isFileLevelFormat() {
     
     
       public long size() throws IOException {
    -    Map<String, Long> dataIndexSize = CarbonUtil.calculateDataIndexSize(this);
    +    LOGGER.info("Acquired lock for table for table status updation");
    +    SegmentStatusManager segmentStatusManager =
    +        new SegmentStatusManager(this.getAbsoluteTableIdentifier());
    +    ICarbonLock carbonLock = segmentStatusManager.getTableStatusLock();
    +    Map<String, Long> dataIndexSize = new HashMap<>();
    +    try {
    +      if (carbonLock.lockWithRetries()) {
    +        dataIndexSize = CarbonUtil.calculateDataIndexSize(this, true);
    +      }
    +    } finally {
    +      if (carbonLock.unlock()) {
    +        LOGGER.info("Table unlocked successfully after table status updation");
    +      } else {
    +        LOGGER.error("Unable to unlock Table lock for table during table status updation");
    +      }
    +    }
    --- End diff --
   
    Please move the locking logic outside of carbonTable


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4958/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5109/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6119/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5110/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5111/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4962/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6125/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2344
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2344


---