[GitHub] carbondata pull request #2349: [CARBONDATA-2552]Fix Data Mismatch for Comple...

[qiuchenjian-2]

GitHub user Indhumathi27 opened a pull request:

    https://github.com/apache/carbondata/pull/2349

    [CARBONDATA-2552]Fix Data Mismatch for Complex Data type Array of Timestamp with Dictionary Include

   
    Fix Data Mismatch for Complex Data type Array and Struct of Timestamp with Dictionary Include
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
             NA
     - [x] Any backward compatibility impacted?
             NA
     - [x] Document update required?
              NA
     - [x] Testing done
              NA
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
               NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Indhumathi27/carbondata complex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2349
   
----
commit da5500e29f25c7c9e32edb444ad678d9766279c0
Author: Indhumathi27 <indhumathim27@...>
Date:   2018-05-28T16:47:36Z

    [CARBONDATA-2552]Fix Data Mismatch for Complex Data type Array of Timestamp with Dictionary Include

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2349
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6143/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2349
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4980/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2349
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5128/



---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2349#discussion_r191325961
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java ---
    @@ -95,7 +95,7 @@ public PrimitiveQueryType(String name, String parentname, int blockIndex,
           DimensionRawColumnChunk[] rawColumnChunks, int rowNumber,
           int pageNumber, DataOutputStream dataOutputStream) throws IOException {
         byte[] currentVal = copyBlockDataChunk(rawColumnChunks, rowNumber, pageNumber);
    -    if (!this.isDictionary) {
    +    if (!this.isDictionary && !this.isDirectDictionary) {
    --- End diff --
   
    Please add test cases corresponding to the changes.


---

[qiuchenjian-2]

Github user Indhumathi27 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2349#discussion_r191333564
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java ---
    @@ -95,7 +95,7 @@ public PrimitiveQueryType(String name, String parentname, int blockIndex,
           DimensionRawColumnChunk[] rawColumnChunks, int rowNumber,
           int pageNumber, DataOutputStream dataOutputStream) throws IOException {
         byte[] currentVal = copyBlockDataChunk(rawColumnChunks, rowNumber, pageNumber);
    -    if (!this.isDictionary) {
    +    if (!this.isDictionary && !this.isDirectDictionary) {
    --- End diff --
   
    okay


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2349
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4993/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2349
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5136/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2349
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6156/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2349
 
    LGTM


---

[qiuchenjian-2]

Github user Indhumathi27 closed the pull request at:

    https://github.com/apache/carbondata/pull/2349


---