[GitHub] carbondata pull request #2354: [WIP] Remove dead code

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6602/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5433/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6608/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5490/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5438/



---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2354#discussion_r198796619
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/ManageDictionaryAndBTree.java ---
    @@ -131,22 +119,4 @@ public static void removeDictionaryColumnFromCache(AbsoluteTableIdentifier carbo
         dictCache = CacheProvider.getInstance().createCache(CacheType.FORWARD_DICTIONARY);
         dictCache.invalidate(dictionaryColumnUniqueIdentifier);
       }
    -
    -  /**
    -   * This method will remove the BTree instances from LRU cache
    -   *
    -   * @param absoluteTableIdentifier
    -   * @param segments
    -   */
    -  public static void invalidateBTreeCache(AbsoluteTableIdentifier absoluteTableIdentifier,
    -      String[] segments) {
    -    Cache<Object, Object> driverBTreeCache =
    -        CacheProvider.getInstance().createCache(CacheType.DRIVER_BTREE);
    --- End diff --
   
    This code is required to clear Btree Cache of BLOCKLET_TREE


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2354#discussion_r199524101
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/ManageDictionaryAndBTree.java ---
    @@ -131,22 +119,4 @@ public static void removeDictionaryColumnFromCache(AbsoluteTableIdentifier carbo
         dictCache = CacheProvider.getInstance().createCache(CacheType.FORWARD_DICTIONARY);
         dictCache.invalidate(dictionaryColumnUniqueIdentifier);
       }
    -
    -  /**
    -   * This method will remove the BTree instances from LRU cache
    -   *
    -   * @param absoluteTableIdentifier
    -   * @param segments
    -   */
    -  public static void invalidateBTreeCache(AbsoluteTableIdentifier absoluteTableIdentifier,
    -      String[] segments) {
    -    Cache<Object, Object> driverBTreeCache =
    -        CacheProvider.getInstance().createCache(CacheType.DRIVER_BTREE);
    --- End diff --
   
    handled.Updated the cachetype to blocklet


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5544/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5565/



---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2354#discussion_r199743291
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/ManageDictionaryAndBTree.java ---
    @@ -131,22 +119,4 @@ public static void removeDictionaryColumnFromCache(AbsoluteTableIdentifier carbo
         dictCache = CacheProvider.getInstance().createCache(CacheType.FORWARD_DICTIONARY);
         dictCache.invalidate(dictionaryColumnUniqueIdentifier);
       }
    -
    -  /**
    -   * This method will remove the BTree instances from LRU cache
    -   *
    -   * @param absoluteTableIdentifier
    -   * @param segments
    -   */
    -  public static void invalidateBTreeCache(AbsoluteTableIdentifier absoluteTableIdentifier,
    -      String[] segments) {
    -    Cache<Object, Object> driverBTreeCache =
    -        CacheProvider.getInstance().createCache(CacheType.DRIVER_BTREE);
    --- End diff --
   
    blocket tree is handled through datamaps. not in this flow


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5561/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5567/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6743/



---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2354#discussion_r200331203
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -261,8 +261,6 @@ public static ColumnGroupModel getColGroupModel(int[][] columnGroups) {
         }
         ColumnGroupModel colGroupModel = new ColumnGroupModel();
    --- End diff --
   
    This columngroup class can also be removed


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2354#discussion_r200345615
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java ---
    @@ -1218,11 +1217,8 @@ public static boolean isHorizontalCompactionEnabled() {
           blockDetails.setDeleteDeltaEndTimestamp(timestamp.toString());
     
           try {
    -        if (startCompactionDeleteDeltaFiles(deleteFilePathList, blockName, fullBlockFilePath)) {
    -          blockDetails.setCompactionStatus(true);
    -        } else {
    -          blockDetails.setCompactionStatus(false);
    -        }
    +        startCompactionDeleteDeltaFiles(deleteFilePathList, blockName, fullBlockFilePath);
    --- End diff --
   
    make startCompactionDeleteDeltaFiles return type void


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2354#discussion_r200544559
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -261,8 +261,6 @@ public static ColumnGroupModel getColGroupModel(int[][] columnGroups) {
         }
         ColumnGroupModel colGroupModel = new ColumnGroupModel();
    --- End diff --
   
    handled


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6874/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2354
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5665/



---