[GitHub] carbondata pull request #2355: [CARBONDATA-2508] Fix the exception that can'...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2355

    [CARBONDATA-2508] Fix the exception that can't get executorService when start search mode twice

    Fix the exception that can't get executorService when start search mode twice:
    1.remove the static code block in SearchModeDetailQueryExecutor and SearchModeVectorDetailQueryExecutor
    2.invoke initThreadPool in constructor of class
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
         add some test case
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2508-searchModeStartAgain

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2355
   
----
commit ec29d75b0fe5592d46be4c665b957c416077563d
Author: xubo245 <xubo29@...>
Date:   2018-05-30T07:45:49Z

    [CARBONDATA-2508] Fix the exception that can't get executorService when start search mode twice
    1.remove the static code block in SearchModeDetailQueryExecutor and SearchModeVectorDetailQueryExecutor
    2.invoke initThreadPool in constructor of class

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6183/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5022/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    @jackylk CI pass, please review it.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5157/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    please rebase


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5165/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6191/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5030/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    @jackylk rebased and CI pass.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2355#discussion_r191982293
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/SearchModeVectorDetailQueryExecutor.java ---
    @@ -40,7 +40,7 @@
               LogServiceFactory.getLogService(SearchModeVectorDetailQueryExecutor.class.getName());
       private static ExecutorService executorService = null;
     
    -  static {
    +  public SearchModeVectorDetailQueryExecutor() {
         initThreadPool();
    --- End diff --
   
    should check whether it is null


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2355#discussion_r191982462
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -100,6 +100,7 @@ class CarbonSession(@transient val sc: SparkContext,
                 trySearchMode(qe, sse)
               } catch {
                 case e: Exception =>
    +              e.printStackTrace()
    --- End diff --
   
    remove this


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2355#discussion_r191985218
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -100,6 +100,7 @@ class CarbonSession(@transient val sc: SparkContext,
                 trySearchMode(qe, sse)
               } catch {
                 case e: Exception =>
    +              e.printStackTrace()
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6195/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5035/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2355


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2355
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5170/



---