[GitHub] carbondata pull request #2356: [CARBONDATA-2566] Optimize CarbonReaderExampl...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2356
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5192/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2356
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5055/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2356
 
    @jacky CI pass, please check it


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2356#discussion_r192302499
 
    --- Diff: docs/sdk-guide.md ---
    @@ -408,17 +408,22 @@ External client can make use of this reader to read CarbonData files without Car
         String path = "./testWriteFiles";
         CarbonReader reader = CarbonReader
             .builder(path, "_temp")
    -        .projection(new String[]{"name", "age"})
    +        .projection(new String[]{"stringField", "shortField", "intField", "longField",
    --- End diff --
   
    All an example for ProjectAllColumns


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2356#discussion_r192310351
 
    --- Diff: docs/sdk-guide.md ---
    @@ -408,17 +408,22 @@ External client can make use of this reader to read CarbonData files without Car
         String path = "./testWriteFiles";
         CarbonReader reader = CarbonReader
             .builder(path, "_temp")
    -        .projection(new String[]{"name", "age"})
    +        .projection(new String[]{"stringField", "shortField", "intField", "longField",
    --- End diff --
   
    ok,done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2356
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6223/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2356
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5195/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2356
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5061/



---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/2356
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2356


---