[GitHub] carbondata pull request #2362: [CARBONDATA-2578] RowBatch is closed when rea...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5135/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5256/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5257/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5258/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6300/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5137/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5259/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5260/



---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2362#discussion_r193962103
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
    @@ -74,6 +74,8 @@ public boolean hasNext() throws IOException, InterruptedException {
             return false;
           } else {
             index++;
    +        // current reader is closed
    +        currentReader.close();
    --- End diff --
   
    @sujith71955 this we cant do in finally block because if we will do it in finally it wiill close immendiately currentReader . currentReader we are using to iterate rows. so its better to close last currentReader before getting new currentReader.


---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2362#discussion_r193963265
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala ---
    @@ -401,7 +402,7 @@ class TestNonTransactionalCarbonTable extends QueryTest with BeforeAndAfterAll {
         intercept[RuntimeException] {
           buildTestDataWithSortColumns(List(""))
         }
    -    
    +
    --- End diff --
   
    it improves readability of test-cases. like that only rest of test-cases added.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5262/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6303/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5140/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2362
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2362


---