[GitHub] carbondata pull request #2372: [SearchMode] Change RPC implementation to Had...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5311/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6364/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5202/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5312/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5313/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2372#discussion_r196633489
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
    @@ -80,7 +80,7 @@ public void initialize(InputSplit inputSplit, TaskAttemptContext context)
         }
         // It should use the exists tableBlockInfos if tableBlockInfos of queryModel is not empty
         // otherwise the prune is no use before this method
    -    if (!queryModel.isFG()) {
    +    if (queryModel.getTableBlockInfos().isEmpty()) {
    --- End diff --
   
    If use  (queryModel.getTableBlockInfos().isEmpty()),  when the prune result is empty by FG in search mode, it will use the original TableBlockInfos and execute again, it mean the FG no use in this scenario. So we cannot change it to queryModel.getTableBlockInfos().isEmpty()


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2372#discussion_r196823447
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
    @@ -80,7 +80,7 @@ public void initialize(InputSplit inputSplit, TaskAttemptContext context)
         }
         // It should use the exists tableBlockInfos if tableBlockInfos of queryModel is not empty
         // otherwise the prune is no use before this method
    -    if (!queryModel.isFG()) {
    +    if (queryModel.getTableBlockInfos().isEmpty()) {
    --- End diff --
   
    I have added a new RecordReader called `IndexedRecordReader`, I am using this one in search mode now. So this problem will not come. I will remove line 83.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5258/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6425/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6428/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5363/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5364/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6433/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5264/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6458/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5290/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5383/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2372#discussion_r197431627
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/SearchModeTestCase.scala ---
    @@ -137,7 +149,7 @@ class SearchModeTestCase extends QueryTest with BeforeAndAfterAll {
         sql("DROP DATAMAP if exists dm3 ON TABLE main")
       }
     
    -  test("start search mode twice") {
    +  ignore("start search mode twice") {
    --- End diff --
   
    Why ignore it?


---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2372
 
    please close it, already merged into the branch carbonstore
    .


---

[qiuchenjian-2]

Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/2372


---