[GitHub] carbondata pull request #2373: [CARBONDATA-2593] Add an option 'carbon.inser...

[qiuchenjian-2]

GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/2373

    [CARBONDATA-2593] Add an option 'carbon.insert.storage.level' to support configuring the storage level when insert into data with 'carbon.insert.persist.enable'='true'

    When insert into data with 'carbon.insert.persist.enable'='true', the storage level of dataset is 'MEMORY_AND_DISK',
    it should support configuring the storage level to correspond to different environment.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?  No
     
     - [ ] Any backward compatibility impacted?  No
     
     - [ ] Document update required?   No
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2373
   
----
commit 9c09e9dec9f5356c0ddd905d0588a868c5b26aa8
Author: Zhang Zhichao <441586683@...>
Date:   2018-06-14T06:48:47Z

    [CARBONDATA-2593]Add an option 'carbon.insert.storage.level' to support configuring the storage level when insert into data with 'carbon.insert.persist.enable'='true'
   
    When insert into data with 'carbon.insert.persist.enable'='true', the storage level of dataset is 'MEMORY_AND_DISK',
    it should support configuring the storage level to correspond to different environment.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6334/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5285/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5172/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6335/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5173/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    @ravipesala @jackylk please help to review, thanks.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2373#discussion_r195622403
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -874,6 +874,26 @@
        */
       public static final String CARBON_INSERT_PERSIST_ENABLED_DEFAULT = "false";
     
    +  /**
    +   * Which storage level to persist dataset when insert into data
    +   * with 'carbon.insert.persist.enable'='true'
    +   */
    +  @CarbonProperty
    +  public static final String CARBON_INSERT_STORAGE_LEVEL =
    --- End diff --
   
    Please put an annotation: @InterfaceStability


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2373#discussion_r195622434
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -874,6 +874,26 @@
        */
       public static final String CARBON_INSERT_PERSIST_ENABLED_DEFAULT = "false";
     
    +  /**
    +   * Which storage level to persist dataset when insert into data
    +   * with 'carbon.insert.persist.enable'='true'
    +   */
    +  @CarbonProperty
    +  public static final String CARBON_INSERT_STORAGE_LEVEL =
    +      "carbon.insert.storage.level";
    --- End diff --
   
    please add it to document also: https://github.com/apache/carbondata/blob/master/docs/configuration-parameters.md



---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2373#discussion_r195648481
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -874,6 +874,26 @@
        */
       public static final String CARBON_INSERT_PERSIST_ENABLED_DEFAULT = "false";
     
    +  /**
    +   * Which storage level to persist dataset when insert into data
    +   * with 'carbon.insert.persist.enable'='true'
    +   */
    +  @CarbonProperty
    +  public static final String CARBON_INSERT_STORAGE_LEVEL =
    --- End diff --
   
    Done


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2373#discussion_r195648504
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -874,6 +874,26 @@
        */
       public static final String CARBON_INSERT_PERSIST_ENABLED_DEFAULT = "false";
     
    +  /**
    +   * Which storage level to persist dataset when insert into data
    +   * with 'carbon.insert.persist.enable'='true'
    +   */
    +  @CarbonProperty
    +  public static final String CARBON_INSERT_STORAGE_LEVEL =
    +      "carbon.insert.storage.level";
    --- End diff --
   
    Done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6351/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5189/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6354/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5192/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5302/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2373
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2373


---