[GitHub] carbondata pull request #2376: [CARBONDATA-2610] Fix for Null values in data...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2376: [CARBONDATA-2610] Fix for Null values in data...

qiuchenjian-2
GitHub user jatin9896 opened a pull request:

    https://github.com/apache/carbondata/pull/2376

    [CARBONDATA-2610] Fix for Null values in datamap

    Problem: Datamap creation having null values already loaded in string datatype of table fails.
    Solution: Check for null before converting data to the string.
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required? Yes
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jatin9896/incubator-carbondata bug/Carbondata-2610

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2376
   
----
commit 776712a01863749c4047de00a25ff1f71df88537
Author: Jatin <jatin.demla@...>
Date:   2018-06-14T17:26:09Z

    Fix for Null values in datamap

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2376: [CARBONDATA-2610] Fix for datamap creation failed on...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2376
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5184/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2376: [CARBONDATA-2610] Fix for datamap creation failed on...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2376
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5294/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2376: [CARBONDATA-2610] Fix for datamap creation failed on...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2376
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6346/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2376: [CARBONDATA-2610] Fix for datamap creation failed on...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2376
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5296/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2376: [CARBONDATA-2610] Fix for datamap creation failed on...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2376
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2376: [CARBONDATA-2610] Fix for datamap creation fa...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2376


---