[GitHub] carbondata pull request #2386: [CARBONDATA-2616][BloomDatamap] Fix bugs in q...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2386

    [CARBONDATA-2616][BloomDatamap] Fix bugs in querying bloomfilter with two index columns

    During pruning in bloomfilter datamap, the same blocklets has been added
    to result more than once, thus causing explaining and querying returning
    incorrect result.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0621_bloom_explain_negative

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2386
   
----
commit 037994413c0348995ffad274238d03928144f112
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-06-20T08:31:28Z

    Fix bugs in querying bloomfilter with two index columns
   
    During pruning in bloomfilter datamap, the same blocklets has been added
    to result more than once, thus causing explaining and querying returning
    incorrect result.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2386
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5242/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2386
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6409/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2386
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5352/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2386#discussion_r197002129
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java ---
    @@ -85,7 +86,7 @@ public void setIndexedColumn(Set<String> indexedColumn) {
       @Override
       public List<Blocklet> prune(FilterResolverIntf filterExp, SegmentProperties segmentProperties,
           List<PartitionSpec> partitions) {
    -    List<Blocklet> hitBlocklets = new ArrayList<Blocklet>();
    +    Set<Blocklet> hitBlocklets = new HashSet<>();
    --- End diff --
   
    There is one optimization we can add: If the blocklet is hit, then skip the following filter condition test for the same blocklet.
    Please raise another JIRA to track this optimization.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2386
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2386


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2386#discussion_r197700953
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java ---
    @@ -85,7 +86,7 @@ public void setIndexedColumn(Set<String> indexedColumn) {
       @Override
       public List<Blocklet> prune(FilterResolverIntf filterExp, SegmentProperties segmentProperties,
           List<PartitionSpec> partitions) {
    -    List<Blocklet> hitBlocklets = new ArrayList<Blocklet>();
    +    Set<Blocklet> hitBlocklets = new HashSet<>();
    --- End diff --
   
    OK, JIRA CARBONDATA-2643 is raised


---