[GitHub] carbondata pull request #2395: [HOTFIX][32K]maintain proper mapping for varC...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2395: [HOTFIX][32K]maintain proper mapping for varC...

qiuchenjian-2
GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2395

    [HOTFIX][32K]maintain proper  mapping for varChar Columns and noDictionary Columns  for all the dimensions while creating sort data rows instance

   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [x] Testing done
    UTs will take care
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata hot_fix_32k

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2395
   
----
commit 1736f4594b8cec599db8dc6457b0b0b6cefaa0b0
Author: akashrn5 <akashnilugal@...>
Date:   2018-06-21T13:27:07Z

    maintain proper  mapping for varChar Columns and noDictionary Columns for all the dimensions while creating sort data rows instance

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2395: [HOTFIX][32K]maintain proper mapping for varChar Col...

qiuchenjian-2
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2395
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2395: [HOTFIX][32K]maintain proper mapping for varChar Col...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2395
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5374/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2395: [HOTFIX][32K]maintain proper mapping for varChar Col...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2395
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5283/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2395: [HOTFIX][32K]maintain proper mapping for varChar Col...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2395
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6452/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2395: [HOTFIX][32K]maintain proper mapping for varChar Col...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2395
 
    @xuchuanyin please review it again, and then we can take this fix


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2395: [HOTFIX][32K]maintain proper mapping for varChar Col...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2395
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2395: [HOTFIX][32K]maintain proper mapping for varChar Col...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2395
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2395: [HOTFIX][32K]maintain proper mapping for varC...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2395


---