[GitHub] carbondata pull request #2396: [WIP] Complex data type enhancements

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2396#discussion_r197502390
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/ArrayQueryType.java ---
    @@ -97,4 +99,56 @@ public void parseBlocksAndReturnComplexColumnByteArray(DimensionRawColumnChunk[]
         return DataTypeUtil.getDataTypeConverter().wrapWithGenericArrayData(data);
       }
     
    +  @Override public Object getDataBasedOnColumn(ByteBuffer dataBuffer, CarbonDimension parent,
    +      CarbonDimension child) {
    +    int dataLength;
    +    if (parent.getOrdinal() < child.getOrdinal()) {
    +      dataLength = parent.getNumberOfChild();
    +
    +      if (dataLength == -1) {
    +        return null;
    +      }
    +      Object[] data = new Object[dataLength];
    +      for (int i = 0; i < dataLength; i++) {
    +        data[i] = children
    +            .getDataBasedOnColumn(dataBuffer, parent.getListOfChildDimensions().get(i), child);
    +      }
    +      return DataTypeUtil.getDataTypeConverter().wrapWithGenericArrayData(data);
    +    } else if (parent.getOrdinal() > child.getOrdinal()) {
    +      return null;
    +    } else {
    +      // dataLength = dataBuffer.getInt();
    +      return DataTypeUtil.getDataTypeConverter()
    +          .wrapWithGenericArrayData(getDataBasedOnDataType(dataBuffer));
    +    }
    +  }
    +
    +  @Override public Object getDataBasedOnColumnList(Map<CarbonDimension, ByteBuffer> childBuffer,
    --- End diff --
   
    Don't implement it, throw unsupported exception


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5399/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5402/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5408/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6486/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5317/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6487/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5318/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5409/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6488/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5319/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5410/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6498/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5418/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5329/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5419/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6499/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5330/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2396
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5420/



---

[qiuchenjian-2]

Github user Indhumathi27 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2396#discussion_r197644949
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -665,6 +665,34 @@ public CarbonDimension getDimensionByName(String tableName, String columnName) {
           if (dim.getColName().equalsIgnoreCase(columnName)) {
             carbonDimension = dim;
             break;
    +      } else if (dim.getListOfChildDimensions() != null) {
    --- End diff --
   
    simplified. please check


---