[GitHub] carbondata pull request #2397: [HOTFIX]ADD carbon.load.sortMemory.spill.perc...

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2397#discussion_r199041537
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonLoadOptionConstants.java ---
    @@ -144,8 +144,8 @@
        * If the sort memory is insufficient, spill inmemory pages to disk.
        * The total amount of pages is at most the specified percentage of total sort memory. Default
        * value 0 means that no pages will be spilled and the newly incoming pages will be spilled,
    -   * whereas value 1 means that all pages will be spilled and newly incoming pages will be loaded
    -   * into sort memory.
    +   * whereas value 100 means that all pages will be spilled and newly incoming pages will be loaded
    +   * into sort memory, Other percentage values range 0-100.
    --- End diff --
   
    please refine this sentence


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6646/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6648/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5475/



---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    retest this case please


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    retest this please


---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    @chenliang613 This parameter controls how large sort temp file merge in memory


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6682/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5508/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2397
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2397


---