[GitHub] carbondata pull request #2399: [CARBONDATA-2629] SDK carbon reader support f...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2399

    [CARBONDATA-2629] SDK carbon reader support filter in HDFS and S3

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2629-SDKFilterInHDFS

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2399
   
----
commit adcb460003d14f723baff01a9465105a2eaba208
Author: xubo245 <xubo29@...>
Date:   2018-06-22T11:51:50Z

    [CARBONDATA-2629] SDK carbon reader support filter in HDFS and S3

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6474/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5305/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6475/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5306/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    @ajantha-bhat @ravipesala @jackylk @sounakr  Please review it please.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5396/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5397/



---

[qiuchenjian-2]

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    LGTM


---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2399#discussion_r198716317
 
    --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/SDKS3Example.java ---
    @@ -60,13 +63,19 @@ public static void main(String[] args) throws Exception {
             }
             writer.close();
             // Read data
    +
    +        EqualToExpression equalToExpression = new EqualToExpression(
    --- End diff --
   
    Please add examples for other expression supported. Like > , < ,in ,not in,, etc..
   
    I think we need to review once the Expression classes can be given as API or we need to refactor to extract if it has internal details which SDK users not needed.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2399#discussion_r199080380
 
    --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/SDKS3Example.java ---
    @@ -60,13 +63,19 @@ public static void main(String[] args) throws Exception {
             }
             writer.close();
             // Read data
    +
    +        EqualToExpression equalToExpression = new EqualToExpression(
    --- End diff --
   
    ok, I add greater and less than , in, not in, NotEqual in carbonReaderTest
   
    Yeah, we can optimize filter Api  in the future


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6639/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5511/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5467/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6651/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5478/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6653/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2399
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5480/



---